Repository navigation
🔒 Fix unsafe PowerShell execution in notification standard library - #354
Tcode-Motion wants to merge 2 commits into
Conversation
Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…stabilize thread example sleep timing Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
🎯 What: Hardened PowerShell execution in standard notification library (
stdlib/src/notification.rs) by adding-NoProfileand-NonInteractiveflags and refactoring argument construction into a cross-platform testable helper function.-NoProfileand-NonInteractiveflags allows execution of untrusted user profile scripts (Microsoft.PowerShell_profile.ps1) when launchingpowershell.exe, potentially allowing privilege escalation or arbitrary code execution via profile hijacking.🛡️ Solution: Updated
stdlib/src/notification.rsto include-NoProfileand-NonInteractiveflags when spawning PowerShell, preventing user profile script execution and interactive stalls. Refactored argument construction intobuild_powershell_notification_argsand added unit tests to verify security flags and safe encoding of arbitrary input strings.PR created automatically by Jules for task 18421920614302179730 started by @Tcode-Motion